Fixes #721 Replace usage of FILTER_SANITIZE_STRING
#722
+107
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrochetFeve0251
approved these changes
Apr 18, 2023
Contributor
|
@Tabrisrp I checked the PR and the issue described in the original issue is resolved. 👏 I'm seeing the following notices in the PHP Warning: Undefined array key "page" in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-views.php on line 468
PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/example.com/htdocs/wp-content/plugins/imagify-plugin/inc/classes/class-imagify-views.php on line 468These are there both with PHP 8.1 & 8.2. To reproduce:
Can you please look into this? 🙏 |
remyperona
changed the title
FILTER_SANITIZE_STRINGFILTER_SANITIZE_STRING
Contributor
Author
|
@vmanthos Good catch, fixed it! |
vmanthos
approved these changes
May 26, 2023
Contributor
vmanthos
left a comment
vmanthos
left a comment
There was a problem hiding this comment.
Thank you for the fix, @Tabrisrp! 🙏
This is working as expected! 👍
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721
Replace usage of
FILTER_SANITIZE_STRINGbyhtmlspecialchars(), as per the official PHP docs recommendation.